New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change mainnet address version. #80

Merged
merged 5 commits into from Oct 28, 2017

Conversation

Projects
None yet
9 participants
@h4x3rotab
Contributor

h4x3rotab commented Oct 24, 2017

  • Prefix 38 (G) for P2PKH.
  • Prefix 23 (A) for P2SH.
  • Convert tool: bgold-cli -testnet=false -convertaddress=<old-address>

Status:

  • Change format version for mainnet.
  • All test cases
  • Tool to convert addresses from old to new format.
Change mainnet address version.
- Prefix 38 (G) for P2PKH.
- Prefix 90 (d) for P2SH.
@leto

This comment has been minimized.

Show comment
Hide comment
@leto

leto Oct 24, 2017

Contributor

@h4x3rotab any reason to use d instead of g which I think would be more intuitive for users. Is that already taken by something?

Contributor

leto commented Oct 24, 2017

@h4x3rotab any reason to use d instead of g which I think would be more intuitive for users. Is that already taken by something?

Show outdated Hide outdated src/chainparams.cpp
@h4x3rotab

This comment has been minimized.

Show comment
Hide comment
@h4x3rotab

h4x3rotab Oct 25, 2017

Contributor

@h4x3rotab any reason to use d instead of g which I think would be more intuitive for users. Is that already taken by something?

Same letter might be a bit confusing.

Contributor

h4x3rotab commented Oct 25, 2017

@h4x3rotab any reason to use d instead of g which I think would be more intuitive for users. Is that already taken by something?

Same letter might be a bit confusing.

Change P2SH prefix to "A" (23).
Also fixed unit tests.

@h4x3rotab h4x3rotab referenced this pull request Oct 26, 2017

Closed

Change address version #17

@h4x3rotab h4x3rotab merged commit 7a2c74d into BTCGPU:master Oct 28, 2017

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@h4x3rotab h4x3rotab changed the title from [WIP] Change mainnet address version. to Change mainnet address version. Oct 28, 2017

@Ayms

This comment has been minimized.

Show comment
Hide comment
@Ayms

Ayms commented Oct 30, 2017

FYI, see simple conversion (and BIP32 wallets) tool: https://github.com/Ayms/bitcoin-wallets#use---convert-bitcoin-addresses

@Emendiz

This comment has been minimized.

Show comment
Hide comment
@Emendiz

Emendiz Nov 10, 2017

Doubt: So, I have converted my BTC address to a the BTG address format successfully.

How about the private key? I tried the same command and it did not work... or that one remains exactly the same?

Thanks!

Emendiz commented Nov 10, 2017

Doubt: So, I have converted my BTC address to a the BTG address format successfully.

How about the private key? I tried the same command and it did not work... or that one remains exactly the same?

Thanks!

@idemin

This comment has been minimized.

Show comment
Hide comment
@idemin

idemin Nov 10, 2017

Private key remains the same.

idemin commented Nov 10, 2017

Private key remains the same.

@srunyo

This comment has been minimized.

Show comment
Hide comment
@srunyo

srunyo commented on src/chainparams.cpp in 4bdf8a8 Nov 11, 2017

@shakilmia

This comment has been minimized.

Show comment
Hide comment
@shakilmia

shakilmia commented on 4bdf8a8 Nov 13, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment