Adds multilevel index, deprecation warnings, column name as callable #67
Conversation
|
|
||
| # TODO: allow this at some future point | ||
| if agg == "all": | ||
| raise AttributeError("cannot use 'all' as aggregate at this time") |
There was a problem hiding this comment.
What would happen if agg is something other than mean, min, max, etc?
There was a problem hiding this comment.
KeyError I believe. I'm fine with not protecting against that.
| item[col] = getattr(row[idx], agg) if row[idx] else None | ||
| if agg == "all": | ||
| for stat in _STAT_PROPERTIES: | ||
| item["{}-{}".format(col, stat)] = getattr(row[idx], stat) if row[idx] else None |
| raise AttributeError("cannot use 'all' as aggregate at this time") | ||
|
|
||
| if not callable(name_callable): | ||
| name_callable = lambda s: s.collection + "/" + s.name |
There was a problem hiding this comment.
Do we want to raise something here? It might be confusing if the user expects the columns to have custom names, but they aren't appearing and they wouldn't know why?
There was a problem hiding this comment.
Hmm.. this is mostly checking for None and making sure they user gave us something valid. I'll add a ticket to rethink this in the future.
tests/btrdb/test_transformers.py
Outdated
| """ | ||
| assert to_dateframe uses name lambda | ||
| """ | ||
| columns = ["stream0", "stream1", "stream2", "stream3"] |
There was a problem hiding this comment.
I don't really understand the purpose of columns here?
There was a problem hiding this comment.
yup, thats leftover. I've deleted in a new commit
No description provided.