Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
LogLayer #2090
Conversation
jeffdonahue
changed the title from
Log Layer to LogLayer
Mar 10, 2015
jeffdonahue
added the
ready for review
label
Mar 10, 2015
|
@pannous I do think |
longjon
commented on the diff
May 14, 2015
| @@ -33,6 +33,7 @@ extern "C" { | ||
| DEFINE_VSL_UNARY_FUNC(Sqr, y[i] = a[i] * a[i]); | ||
| DEFINE_VSL_UNARY_FUNC(Exp, y[i] = exp(a[i])); | ||
| +DEFINE_VSL_UNARY_FUNC(Ln, y[i] = log(a[i])); |
longjon
Contributor
|
|
This looks good to me as a counterpart to As a more general issue affecting both of these, however, I wonder if this is the best way to resolve the tension between granularity and functionality. As far as I can tell, these layers could just implement simple |
|
@longjon yeah, I put the shift/scale fields in to match the existing |
shelhamer
added the
needs rebase
label
Jun 1, 2015
|
Looks good to me.
This is fine. It could make for a nice warm-up PR in the future. @jeffdonahue rebase and merge away. |
jeffdonahue
added a commit
that referenced
this pull request
Jun 3, 2015
|
|
jeffdonahue |
2d137e1
|
jeffdonahue
merged commit 2d137e1
into
BVLC:master
Jun 3, 2015
1 check passed
|
Thanks for the review @shelhamer and @longjon! |
jeffdonahue commentedMar 10, 2015
This adds
LogLayer, aNeuronLayer, which by default takes the natural log of its inputs. It's designed analogously toExpLayerandPowerLayer. (In general computeslog_{\gamma}(\alpha x + \beta)withlog_param { base: \gamma scale: \alpha shift: \beta }.)