Malloc at least one byte in Parallel #2924

Merged
merged 1 commit into from Aug 14, 2015

Conversation

Projects
None yet
2 participants
Member

ronghanghu commented Aug 14, 2015

This seems to be a simple workaround to fix #2922.

I'll merge once Travis CI pass.

Contributor

thatguymike commented Aug 14, 2015

Hrmm, probably better to actually look at the root issue. Seems like on the mallocs we should check layer state. Although this patch will workaround the issue, we should probably have a more general debate on what the behavior should even be training with no learnable params.

Member

ronghanghu commented Aug 14, 2015

Although this patch will workaround the issue, we should probably have a more general debate on what the behavior should even be training with no learnable params.

I agree. It doesn't make sense to me to train without learnable params (maybe someone just want to see the loss of a network? still doesn't quite make sense to me...). Perhaps train without learnable params should be banned in the future?

Since it is a simple 3 line workaround, I'll first merge this, and debates can follow in new issues.

@ronghanghu ronghanghu added a commit that referenced this pull request Aug 14, 2015

@ronghanghu ronghanghu Merge pull request #2924 from ronghanghu/fix-malloc-empty
Malloc at least one byte in Parallel
33e5b39

@ronghanghu ronghanghu merged commit 33e5b39 into BVLC:master Aug 14, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

ronghanghu deleted the ronghanghu:fix-malloc-empty branch Aug 25, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment