Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
NetSpec: type-check Function inputs (they must be Top instances) #3153
Conversation
jeffdonahue
added the
ready for review
label
Oct 5, 2015
longjon
was assigned
by jeffdonahue
Oct 5, 2015
|
( |
shelhamer
merged commit 1df3a25
into
BVLC:master
Apr 14, 2017
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
|
Thanks for the net spec check Jeff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jeffdonahue commentedOct 5, 2015
This adds simple type-checking for a common (at least for me) class of NetSpec use errors: the use of non-
Topinstances as inputs toFunctions. The exception is raised when theFunctionis__init__ed rather than lazily whento_protois called, making it easier to debug (IMO).