Fix CuDNNConvolutionLayer for cuDNN v4 #3439

Merged
merged 1 commit into from Dec 12, 2015

Conversation

Projects
None yet
3 participants
Contributor

flx42 commented Dec 10, 2015

Add a macro to check the current cuDNN version

Contributor

flx42 commented Dec 10, 2015

The CMake website is under maintenance, causing the automated cmake builds to fail.
EDIT: it works now. The automated builds all passed.
ping @shelhamer for review, it should be a quick one.

@flx42 flx42 Fix CuDNNConvolutionLayer for cuDNN v4
Add a macro to check the current cuDNN version
eb2b848
Owner

shelhamer commented Dec 11, 2015

@flx42 will there be further ifdef guards for v4? If not this is simple and done. I'm happy to keep v3 compatibility and add v4 if it doesn't obscure the code. So far we have followed the current cuDNN version and dropped old versions (because of API changes).

Thanks for the PR.

Contributor

thatguymike commented Dec 11, 2015

This is the only change until we get to more feature support like batch normalization. We should generally support the macro to better deal with API change-overs.

Contributor

flx42 commented Dec 11, 2015

For v3 and v4 only, I believe you could simply replace cudnnAddTensor by cudnnAddTensor_v3. But this function is also marked as deprecated so it seems less future-proof.

Owner

shelhamer commented Dec 12, 2015

Ok, agreed on the macro and this is fine as-is.

@shelhamer shelhamer added a commit that referenced this pull request Dec 12, 2015

@shelhamer shelhamer Merge pull request #3439 from flx42/cudnn_v4
Add ifdef in CuDNNConvolutionLayer for cuDNN v4
7953918

@shelhamer shelhamer merged commit 7953918 into BVLC:master Dec 12, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@shelhamer shelhamer added a commit to shelhamer/caffe that referenced this pull request Apr 14, 2016

@shelhamer shelhamer [docs] install: CUDA 7+ and cuDNN v4 compatible
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR #3439
b265134

@xygorn xygorn added a commit to xygorn/caffe that referenced this pull request Jul 8, 2016

@shelhamer @xygorn shelhamer + xygorn [docs] install: CUDA 7+ and cuDNN v4 compatible
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR #3439
db74876

@fxbit fxbit added a commit to Yodigram/caffe that referenced this pull request Sep 1, 2016

@shelhamer @fxbit shelhamer + fxbit [docs] install: CUDA 7+ and cuDNN v4 compatible
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR #3439
194ad63

@zouxiaochuan zouxiaochuan added a commit to zouxiaochuan/caffe that referenced this pull request Oct 24, 2016

@shelhamer @zouxiaochuan shelhamer + zouxiaochuan [docs] install: CUDA 7+ and cuDNN v4 compatible
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR #3439
3875bb0

@zouxiaochuan zouxiaochuan added a commit to zouxiaochuan/caffe that referenced this pull request Oct 24, 2016

@shelhamer @zouxiaochuan shelhamer + zouxiaochuan [docs] install: CUDA 7+ and cuDNN v4 compatible
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR #3439
daf619b

@zouxiaochuan zouxiaochuan added a commit to zouxiaochuan/caffe that referenced this pull request Feb 15, 2017

@shelhamer @zouxiaochuan shelhamer + zouxiaochuan [docs] install: CUDA 7+ and cuDNN v4 compatible
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR #3439
d142857

@zouxiaochuan zouxiaochuan added a commit to zouxiaochuan/caffe that referenced this pull request Feb 15, 2017

@shelhamer @zouxiaochuan shelhamer + zouxiaochuan [docs] install: CUDA 7+ and cuDNN v4 compatible
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR #3439
300237b

@zouxiaochuan zouxiaochuan added a commit to zouxiaochuan/caffe that referenced this pull request Feb 15, 2017

@shelhamer @zouxiaochuan shelhamer + zouxiaochuan [docs] install: CUDA 7+ and cuDNN v4 compatible
Latest CUDA versions are all compatible, and
Caffe has been compatible with cuDNN v4 since PR #3439
e3d2033
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment