Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Use six library to ensure pycaffe.py python3 compliance #3716
Conversation
seanbell
commented on an outdated diff
Feb 24, 2016
| remainder = num % batch_size | ||
| - num_batches = num / batch_size | ||
| + num_batches = int(num / batch_size) |
seanbell
Contributor
|
ttdt
commented
Feb 25, 2016
|
Use // for integer division (python2 and python3 compliant) |
shelhamer
added the
Python 3
label
Feb 25, 2016
ttdt
closed this
Feb 25, 2016
ttdt
reopened this
Feb 25, 2016
ttdt
commented
Feb 25, 2016
|
CI build fails because of random 404 on package download from repo.continuum.io: https://repo.continuum.io/pkgs/free/linux-64/setuptools-20.1.1-py35_0.tar.bz2 |
ttdt
closed this
Feb 25, 2016
ttdt
reopened this
Feb 25, 2016
longjon
commented on an outdated diff
Feb 26, 2016
| @@ -14,6 +14,9 @@ | ||
| RMSPropSolver, AdaDeltaSolver, AdamSolver | ||
| import caffe.io | ||
| +# py3 compliance | ||
| +from six import itervalues, next, iteritems |
longjon
Contributor
|
|
Looks good except as noted. We should really have tests that cover these cases... |
|
Great, the diff looks good to me now. If you could clean up the history by squashing into a single commit, this will be ready for merge. |
ttdt
closed this
Feb 29, 2016
ttdt
commented
Feb 29, 2016
|
@ttdt in the future do not close the PR, but instead update the PR by force pushing to your branch. Making new PRs adds noise to the tracker. |
ttdt
reopened this
Feb 29, 2016
|
Thanks for the Python 3 update, merging! (By the way, I think you mean "integer division" or "floor division" in the commit message (but it's not worth fixing, just a note for the future)). |
longjon
added a commit
that referenced
this pull request
Mar 3, 2016
|
|
longjon |
559758d
|
longjon
merged commit 559758d
into
BVLC:master
Mar 3, 2016
1 check passed
fxbit
added a commit
to Yodigram/caffe
that referenced
this pull request
Sep 1, 2016
|
|
longjon + fxbit |
86e8a83
|
ttdt commentedFeb 24, 2016
By replacing itervalues, next and iteritems with six library functions, pycaffe.py is now python3 compliant.