Set propagate_down=true to force backprop to a particular bottom #3942

Merged
merged 2 commits into from Apr 5, 2016

Conversation

Projects
None yet
2 participants
Contributor

jeffdonahue commented Apr 4, 2016

Currently setting propagate_down=true has no effect -- only setting propagate_down=false has an effect (disabling backpropagation when it would otherwise be enabled). This PR changes the behavior of propagate_down=true -- if set, backpropagation is forced even if it's not needed, sort of like a per-bottom force_backward=true setting.

Contributor

jeffdonahue commented Apr 4, 2016

It's hard to tell from the reordered history here on GitHub, but the add TestForcePropagateDown commit (dee01c8) is first and the test should fail since the behavior isn't implemented. The second commit (0f36571) is the one that actually updates the behavior and the tests should then pass.

Contributor

jeffdonahue commented Apr 4, 2016

Hm, well, for some reason the tests here both passed, but on my repo's Travis, as expected, the first commit (dee01c8) failed and the second commit (0f36571) passed.

Owner

shelhamer commented Apr 4, 2016

Thanks Jeff, this looks good except that the proto comment for propagate_down should reflect that it now forces both cases whether propagating by true or skipping by false. Feel free to merge once that is included.

Contributor

jeffdonahue commented Apr 5, 2016

Thanks for the review Evan! Proto comment updated.

@jeffdonahue jeffdonahue merged commit 843575e into BVLC:master Apr 5, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

jeffdonahue deleted the jeffdonahue:propagate-down-true branch Apr 5, 2016

ih4cku referenced this pull request in ih4cku/caffe-notes Apr 13, 2016

Open

propagate_down #5

@myfavouritekk myfavouritekk added a commit to myfavouritekk/caffe that referenced this pull request Aug 15, 2016

@myfavouritekk myfavouritekk Set propagate_down=true to force backprop to a particular bottom (bor…
…rowed from BVLC/caffe#3942).
3461901

@fxbit fxbit added a commit to Yodigram/caffe that referenced this pull request Sep 1, 2016

@jeffdonahue @fxbit jeffdonahue + fxbit Merge pull request #3942 from jeffdonahue/propagate-down-true
Set propagate_down=true to force backprop to a particular bottom
08cc2c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment