Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fix Crop layer dimension checking to only check cropped dimensions #3993
+38
−27
Conversation
shelhamer
added the
bug
label
Apr 15, 2016
shelhamer
merged commit 8c66fa5
into
BVLC:master
Apr 15, 2016
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
shelhamer
deleted the
shelhamer:fix-crop branch
Apr 15, 2016
MalteOeljeklaus
referenced
this pull request
Apr 15, 2016
Closed
Only check the dimensions start from start_axis #3778
|
Reported with fix in #3778 by wk910930—thanks for noting the issue! |
shelhamer
added a commit
to shelhamer/fcn.berkeleyvision.org
that referenced
this pull request
Apr 21, 2016
|
|
shelhamer |
190f614
|
fxbit
added a commit
to Yodigram/caffe
that referenced
this pull request
Sep 1, 2016
|
|
shelhamer + fxbit |
fc03da6
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
shelhamer commentedApr 15, 2016
The
Croplayer should only check the actual dimensions to be cropped for shape compatibility given the crop size and offset.The current, over-general check results in issues like refusing to crop the output for a binary classification task given color input, since the data has 3 channels while the output has 2. As the channels are not cropped (in this use case) that is irrelevant and wrong.
This PR fixes the check, makes the message clearer, and revises the comments here and there.