/caffe

Fix more float comparison precision issue #4566

Merged
merged 1 commit into from Apr 14, 2017

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@CDLuminate @shelhamer
@CDLuminate
Contributor

CDLuminate commented Aug 9, 2016

With reference to this commit:
f1a8470

This fix changes some EXPECT_EQ into EXPECT_FLOAT_EQ .
@CDLuminate CDLuminate Fix more float comparison precision issue 
With reference to this commit:
f1a8470

This fix changes some EXPECT_EQ into EXPECT_FLOAT_EQ .
d607858
@CDLuminate
Contributor

CDLuminate commented Aug 9, 2016 • edited

Debian package caffe_1.0.0~rc3~20160715-g42cd785-1 suffers from this problem on ppc64el architecture, see buildlog:

https://buildd.debian.org/status/fetch.php?pkg=caffe&arch=ppc64el&ver=1.0.0~rc3%2B20160715-g42cd785-1&stamp=1470684373
@CDLuminate
Contributor

CDLuminate commented Aug 9, 2016

My local test result is fine.

[  PASSED  ] 1096 tests.
[100%] Built target runtest

I'll apply this patch to the next revision of the debian package, please consider the merger of it.

@shelhamer shelhamer merged commit 861a12d into BVLC:master Apr 14, 2017
1 check failed

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
@shelhamer
Owner

shelhamer commented Apr 14, 2017

Thanks for adjusting the precision to use the right equality check.

@shelhamer shelhamer added a commit that referenced this pull request Apr 14, 2017

@shelhamer shelhamer fix lint errors that snuck in by #4566 8007349

@stingshen stingshen added a commit to stingshen/caffe-faster-rcnn that referenced this pull request Jun 7, 2017

@shelhamer @stingshen shelhamer + stingshen fix lint errors that snuck in by #4566 5399f51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment