Skip to content

Burak Yiğit Kaya
BYK

Organizations

@disqus @jstanbul @DirenGeziParki @eslint
BYK commented on pull request shelljs/shelljs#317
@BYK

(Please do one file per PR) lol - sorry for not following this :D

BYK commented on pull request shelljs/shelljs#317
@BYK

FYI I didn't try to fix all warnings so the warnings are expected. no-param-reassign is extensively violated and requires some fundamental changes …

BYK commented on pull request shelljs/shelljs#317
@BYK

Looks like this is the problem: /home/travis/build/shelljs/shelljs/test/which.js 18:5 error "result" is already defined no-redeclare

BYK commented on pull request shelljs/shelljs#331
@BYK

Okay fixed all of them. There may be rebase errors though so we gotta be careful. If you rebase your branch on top of the latest master, we can get…

BYK pushed to eslint at BYK/shelljs
@BYK
BYK opened pull request shelljs/shelljs#331
@BYK
Update ESlint branch
20 commits with 897 additions and 520 deletions
BYK created branch eslint at BYK/shelljs
BYK commented on pull request shelljs/shelljs#317
@BYK

Adding the following to the rule set helps a lot: "spaced-comment": [2, "always", { "markers": ["@"], "exceptions": ["@"] }]

BYK pushed to master at BYK/shelljs
@BYK
BYK commented on pull request eslint/eslint#4974
@BYK

@rpatil26 - looks like the builds hang for some reason. Restarting fixed Travis. Tried to restart AppVeyor too but not sure if it worked. @nzakas -…

BYK commented on pull request shelljs/shelljs#322
@BYK

Rebased

@BYK
BYK pushed to ignore-idea at BYK/shelljs
@BYK
BYK commented on pull request shelljs/shelljs#321
@BYK

@nfischer - alright, removed a bunch of stuff. What do you think? :)

BYK pushed to ignore-idea at BYK/shelljs
@BYK
  • @BYK 9ae815b
    Rewrite .gitignore to be more comprehensive
BYK commented on pull request scopatz/xonsh#652
@BYK

@scopatz - mine looks like this: {'arc': '/c/Users/BYK/AppData/Roaming/xonsh/completions/arc-completion.bash', 'git': '/c/Users/BYK/AppData/Roaming…

BYK pushed to master at BYK/xonsh
@BYK
BYK commented on pull request shelljs/shelljs#321
@BYK

Well, since you asked for it, I did a much more comprehensive edit (a rewrite at this point) on the file. Updated the commit and PR messages accord…

BYK pushed to ignore-idea at BYK/shelljs
@BYK
  • @BYK 66ea009
    Rewrite .gitignore to be more comprehensive
BYK commented on pull request shelljs/shelljs#317
@BYK

I'm willing to help with this. Have you tried using the --fix option to get some of these fixed autoamtically?

BYK commented on pull request shelljs/shelljs#317
@BYK

We should prefer .eslintrc.json as the file name. "raw" .eslintrc files are deprecated.

BYK commented on issue shelljs/shelljs#198
@BYK

This may also be resolved by #322.

BYK commented on pull request shelljs/shelljs#322
@BYK

Okay, should be fixed now.

@BYK
  • @BYK 65b2121
    Fix symlinking on Windows
BYK commented on pull request shelljs/shelljs#322
@BYK

Gonna fox POSIX issues.

@BYK
  • @BYK c28ed9b
    Fix symlinking on Windows
BYK opened pull request shelljs/shelljs#322
@BYK
Fix symlinking on Windows
1 commit with 90 additions and 59 deletions
@BYK
  • @BYK a459aa6
    Fix symlinking on Windows
Something went wrong with that request. Please try again.