Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 4.08.1 migration #75

Open
wants to merge 21 commits into
base: master
from

Conversation

@darrenldl
Copy link

darrenldl commented Nov 22, 2019

Some notable changes

  • Migration to dune
  • Switched to use of ppx for sexp related functions
  • Switching from presumably ocamlyacc to menhir for parser_yacc.mly (modified file a bit to fit menhir’s syntax)

Also migrated Dlist to dune and added files here and there, may be required for this version of Batsh to build

Thanks @XVilka for providing the opam file - added you to the contributor list as well

EDIT: Fixes #74

@darrenldl darrenldl changed the title Ocaml 4.08.1 migration OCaml 4.08.1 migration Nov 22, 2019
@XVilka

This comment has been minimized.

Copy link

XVilka commented Nov 23, 2019

It will fix also the #74

@darrenldl

This comment has been minimized.

Copy link
Author

darrenldl commented Nov 23, 2019

Updated original message to reflect that. Thanks!

@XVilka XVilka mentioned this pull request Nov 23, 2019
@XVilka

This comment has been minimized.

Copy link

XVilka commented Nov 23, 2019

It also depends on BYVoid/Dlist#3
Since dlist is released in opam - https://opam.ocaml.org/packages/dlist/ it would be nice to push the new version in opam too @BYVoid

@XVilka

This comment has been minimized.

Copy link

XVilka commented Dec 26, 2019

@BYVoid ping? Could you please take a look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.