New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix World Weapon API and functionality #99

Merged
merged 20 commits into from Feb 26, 2018

Conversation

Projects
None yet
2 participants
@allejo
Copy link
Member

allejo commented Feb 24, 2018

  • A lot of refactoring for World Weapon functionality
  • Add new bz_eServerShotFiredEvent
  • Introduce bz_fireServerShot() API function
  • Remove World Weapon shots from all tanks when they've been ended
  • Use a GUID for each World Weapon shot by the API

I'd really appreciate help testing and feedback.

Stuff left to do:

  • test world weapon GMs shot by the API
  • test oncap world weapons
  • Port rabidRabbit, shockwavedeath, wwzones plugins to use new API function

allejo added some commits Feb 23, 2018

Simplify internal world weapon API
- Remove separate functions for world weapons and world guided missiles;
  they're the same thing, basically.
- Return the shot GUID for each WW shot instead of local shot IDs
Move static WW function to a method instead
There's no reason why the API should be troubled with handling shot IDs
so make the WorldWeapons class handle it all
Server shots should always come from ServerPlayer
Remove the parameter that allows otherwise
Fix World Weapons not being removed for all tanks
World Weapons are only being removed from the tank that got killed by it
but they continue for all the other players; this fixes that.

@allejo allejo added the enhancement label Feb 24, 2018

Make world weapon API only use vectors.
add utility functions to convert old angles or targets into a vector.
remove ability for API to override shot params so players can expect consistent behavior from shots.
extend shot meta data to include strings.

@allejo allejo force-pushed the allejo:feature/ww-api branch from 8a0bbb5 to e001476 Feb 25, 2018

@allejo allejo changed the title [WIP] Fix World Weapon API and functionality Fix World Weapon API and functionality Feb 25, 2018

@allejo allejo merged commit 9600a0e into BZFlag-Dev:2.4 Feb 26, 2018

@allejo allejo deleted the allejo:feature/ww-api branch Feb 26, 2018

@allejo allejo referenced this pull request Mar 29, 2018

Merged

Use new bzfs server shot API #17

7 of 7 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment