Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'NI_XZ' control mapping module #22

Merged
merged 18 commits into from Jan 17, 2019
Merged

'NI_XZ' control mapping module #22

merged 18 commits into from Jan 17, 2019

Conversation

rocco8773
Copy link
Member

Adds ability to interface with the 'NI_XZ' control device. The 'NI_XZ' control device is used to moving a probe in the XZ-plane of the LaPD.

This merge includes:

  1. Addition of the HDFMapControlNIXZ class for mapping the 'NI_XZ' control device
    • 100% coverage of tests
  2. HDFReadControl needed to be updated such that the population of the'xyz' field does not fail, since the 'NI_XZ' dataset does not store y-coordinate values
    • Now, when defining the configs mapping dictionary, if the dataset field is defined as a null string '', then HDFReadControl assumes that the corresponding numpy field is supposed to be filled with zeros.
    • For example, if
      configs[cname]['state values']['xyz'] = {
          'dset paths': 'path/to/dataset',
          'dset field': ('x', '', 'z'),
          'shape': (3,),
          'dtype': np.float64,
       }
      
      then the y-coordinate, or data['xyz'][...,1], will be filled with zeros.
    • This will work for any numpy field that has multiple dataset fields mapped to it.
    • Test are updated to maintain 100% coverage

…y field is populated from multiple dataset fields (e.g. the numpy field 'xyz' maps to the 'x', 'y', and 'z' fields in the h5py dataset, but some controls do not include all these fields)
…ected and non-expected fields are missing from a dataset
@rocco8773 rocco8773 added the mapping: control requesting control mapping module label Jan 17, 2019
@rocco8773 rocco8773 added this to the v1.0.1 milestone Jan 17, 2019
@rocco8773 rocco8773 self-assigned this Jan 17, 2019
@rocco8773
Copy link
Member Author

#20

@rocco8773 rocco8773 merged commit b3b114a into master Jan 17, 2019
@rocco8773 rocco8773 added this to In progress in v1.0.1 Features via automation Jan 17, 2019
@rocco8773 rocco8773 moved this from In progress to Done in v1.0.1 Features Jan 18, 2019
@rocco8773 rocco8773 deleted the NI_XZ_control branch May 23, 2019 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mapping: control requesting control mapping module
Projects
To-Do's
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

1 participant