Markus Bachmann Baachi

Organizations

@symfony-translation-de @geocoder-php
Baachi commented on issue portphp/boilerplate#7
@Baachi

Cool thing, didn't noticed this feature :+1:

Baachi commented on issue ddeboer/data-import#240
@Baachi

Can you provide a failing test case?

Baachi commented on pull request portphp/doctrine-adapter#3
@Baachi

First of all i would only allow a QueryInterface, this is more flexible for users who didn't use the query builder. The thing is, it's not really e…

Baachi commented on pull request portphp/doctrine-adapter#3
@Baachi

@sagikazarmark Split this big class in some smaller classes is a good idea.

Baachi commented on pull request portphp/doctrine-adapter#1
@Baachi

Hey Sergey, i would really say thank you for your work. Really great PR :+1: I'm :+1: on this.

Baachi commented on pull request portphp/doctrine-adapter#1
@Baachi

Ah good to know, thanks :+1:

Baachi commented on pull request portphp/doctrine-adapter#1
@Baachi

I would simply throw an Exception if the objectManager property isn't a Doctrine\ORM\EntityManager.

Baachi commented on pull request portphp/doctrine-adapter#1
@Baachi

Are you sure? This will call the autoloader and if the autoloader throws an exception when the class wasn't found my breaks.

Baachi commented on pull request portphp/doctrine-adapter#1
@Baachi

Yeah i think this isn't expected. If i call an method and he does not throw any exception, i would expect that he works.

Baachi commented on pull request portphp/doctrine-adapter#1
@Baachi

Ah okay.

Baachi commented on pull request portphp/doctrine-adapter#1
@Baachi

Should throw an exception if the odm is used.

Baachi commented on pull request portphp/doctrine-adapter#1
@Baachi

Maybe use an use statement here? And what is if only the mongodb-odm is present? I think this will throw an exception or i am wrong?

Baachi commented on pull request portphp/doctrine-adapter#1
@Baachi

Why do you use the query builder here?

Baachi starred rupa/z
Baachi closed issue Baachi/CouchDB#22
@Baachi
Offer caching for HTTP
Baachi commented on pull request portphp/steps#4
@Baachi

The thing is, i agree if we goes with good design this should throw an exception but if we decide to focus on performance this shouldn't be modified.

Baachi commented on pull request portphp/steps#4
@Baachi

This is not a good idea, this will decrease the performance a lot.