New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.0] remove `quotes` option from babel-generator #5139

Closed
hzoo opened this Issue Jan 16, 2017 · 7 comments

Comments

Projects
None yet
5 participants
@hzoo
Member

hzoo commented Jan 16, 2017

(breaking change)

Going to start out by saying babel-generator is the package that takes an AST from the babel plugin/presets and returns a string (your file). As a compile file you probably shouldn't be caring that much about the options here. You're going to minify it in prod as well and it's not the source code where you would use eslint, prettier, etc.

Thus out of the options currently in generator - https://github.com/babel/babel/tree/master/packages/babel-generator#options, the quotes one doesn't make sense because the others have to do with code coverage, minification, or sourcemaps.

This also would fix #4803 (fixing the issue by removing the option)


@4rlekin

This comment has been minimized.

Show comment
Hide comment
@4rlekin

4rlekin Jan 16, 2017

Contributor

"I volunteer as tribute"

Seriously though, im looking for something to engage in open source.
So im willing to take this issue upon myself.

Contributor

4rlekin commented Jan 16, 2017

"I volunteer as tribute"

Seriously though, im looking for something to engage in open source.
So im willing to take this issue upon myself.

@existentialism

This comment has been minimized.

Show comment
Hide comment
@existentialism

existentialism Jan 16, 2017

Member

@4rlekin awesome, and may the odds be ever in your favor :)

Member

existentialism commented Jan 16, 2017

@4rlekin awesome, and may the odds be ever in your favor :)

@4rlekin

This comment has been minimized.

Show comment
Hide comment
@4rlekin

4rlekin Jan 16, 2017

Contributor

First question then: i assume the branch i should be forking for my solution is the 7.0 (currently one commit behind master) ?

Contributor

4rlekin commented Jan 16, 2017

First question then: i assume the branch i should be forking for my solution is the 7.0 (currently one commit behind master) ?

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 16, 2017

Member

Yeah 👍. sorry just haven't merged anything into 7.0 yet, that's all.

Member

hzoo commented Jan 16, 2017

Yeah 👍. sorry just haven't merged anything into 7.0 yet, that's all.

@ggilberth

This comment has been minimized.

Show comment
Hide comment
@ggilberth

ggilberth Jan 18, 2017

@4rlekin - Are you still working on this or may i step in?

ggilberth commented Jan 18, 2017

@4rlekin - Are you still working on this or may i step in?

@4rlekin

This comment has been minimized.

Show comment
Hide comment
@4rlekin

4rlekin Jan 18, 2017

Contributor

I am, unfortunately didn't had much time to spend on it yet. I should report some progres in the next 12 hours i guess.

Contributor

4rlekin commented Jan 18, 2017

I am, unfortunately didn't had much time to spend on it yet. I should report some progres in the next 12 hours i guess.

@hzoo

This comment has been minimized.

Show comment
Hide comment
@hzoo

hzoo Jan 31, 2017

Member

Done in #5154!

Member

hzoo commented Jan 31, 2017

Done in #5154!

@hzoo hzoo closed this Jan 31, 2017

@hzoo hzoo added the pkg: generator label Jun 8, 2017

@hzoo hzoo referenced this issue Sep 16, 2017

Merged

Babel 7 #23966

2 of 2 tasks complete

@lock lock bot added the outdated label May 4, 2018

@lock lock bot locked as resolved and limited conversation to collaborators May 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.