New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scene.workerCollisions doesn't work with mesh instances #3819

Closed
vujadin opened this Issue Feb 25, 2018 · 1 comment

Comments

Projects
None yet
3 participants
@vujadin

vujadin commented Feb 25, 2018

  • Bug repro on http://playground.babylonjs.com/#8007QV (uncomment line 4 to see the problem)
  • Expected result: it should work like with scene.workerCollisions = false;
  • Current result: runtime error - Cannot read property 'geometry' of undefined

does worker starts too early (before mesh instances are created) as instance.sourceMesh is null ??

@deltakosh deltakosh added the bug label Feb 25, 2018

@deltakosh deltakosh added this to the 3.2 milestone Feb 25, 2018

RaananW added a commit to RaananW/Babylon.js that referenced this issue Feb 26, 2018

Collision workers fix
Fixing BabylonJS#3819
Worker collisions are not enabled in the playground , it will only be enabled if the worker is available from now on.
@RaananW

This comment has been minimized.

Member

RaananW commented Feb 26, 2018

No collision workers are available on the playground (to use the workers you will need to use the babylon.workers file in the dist repo). There was also a bug concerning the way the worker is getting the geometry of instances, which was fixed as well.
So, the fallback to workerCollisions in the playground is the regular collisions system.

@RaananW RaananW closed this Feb 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment