Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
The text was updated successfully, but these errors were encountered:
I initially looked at this change: https://github.com/BabylonJS/Babylon.js/pull/7344/files
Reverted via this PR
This change added some extra checking of nodes to be exported and inverted between coordinate systems, and appears to work properly for Left Handed coordinate systems. Unfortunately, we detect whether or not a node is used as a coordnate system transformation via isNodeConvertingToLeftHanded() this particular line seems somewhat suspect:
In that it works when we use a left handed coordinate system, however, round tripped right handed scenes would still have an encapsulating root node, but would have an Identity transform matrix:
I'll add some additional logic to use the proper transform matrix depending on the scene handedness.
Sorry, something went wrong.
In addition, #7377 also indicates some issue with the encapsulating node used to represent punctual lights in glTF, the logic is similar, we need to prevent duplication of a light's node as well:
No branches or pull requests