Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[XR] Support right handed system in XR controller ray calculation #7967

Closed
RaananW opened this issue Apr 2, 2020 · 0 comments
Closed

[XR] Support right handed system in XR controller ray calculation #7967

RaananW opened this issue Apr 2, 2020 · 0 comments
Assignees
@RaananW
Labels
bug VR/AR/XR
Milestone
4.2

Comments

@RaananW
Copy link
Member

RaananW commented Apr 2, 2020

At the moment we assume positive Z is forward in this function:

Babylon.js/src/XR/webXRInputSource.ts

Line 144 in a59653f

this._tmpVector.set(0, 0, 1);

We should change that according to the system used in the scene.
@RaananW RaananW added this to the 4.2 milestone Apr 2, 2020
@RaananW RaananW self-assigned this Apr 2, 2020
@RaananW RaananW mentioned this issue Apr 3, 2020
Merged
@RaananW RaananW closed this as completed Apr 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaananW RaananW

Labels
bug VR/AR/XR
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
1 participant
@RaananW