Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWebXRHitTestOptions should expose options to hit test against XRHitTestTrackableType instead of assume a default implementation #8687

Closed
hendryems opened this issue Aug 5, 2020 · 1 comment
Assignees

Comments

@hendryems
Copy link

Is your feature request related to a problem? Please describe.
When hit testing against real world geometry (e.g. through ARKit/ARCore), the hit test seems to be very specific to a particular implementation.

E.g. On the ARCore implementation [Source link], this is XRHitTestTrackableType.mesh which seems to be the most restrictive.

            // Iterate over the results and pull out only those that match the desired TrackableType.  For now we are limiting results to
            // just hits against the Plane, and further scoping that to Poses that are contained in the polygon of the detected mesh.
            // This is equivalent to XRHitTestTrackableType.mesh (https://immersive-web.github.io/hit-test/#hit-test-trackable-type-enum).

For apps looking to build an app using BabylonJS as its XR abstraction, it is desirable to be able to configure the specifics of what hit testing would be against.

Describe the solution you'd like
When configurating a WebXRHitTest, a XRHitTestTrackableType option (through IWebXRHitTestOptions ?) should be exposed.

Discussion
BabylonJS/BabylonReactNative#53

@RaananW
Copy link
Member

RaananW commented Aug 11, 2020

Sure! makes sense. I have already added entityType to the webxr.d.ts file, it is a matter of exposing it in the configuration. Also noticed the mesh type is missing, will add that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants