Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Projection plane tilt #10530

Merged
merged 7 commits into from Jun 22, 2021
Merged

Projection plane tilt #10530

merged 7 commits into from Jun 22, 2021

Conversation

CraigFeldspar
Copy link
Member

@CraigFeldspar CraigFeldspar commented Jun 21, 2021 •
edited

  • Adding a projectionPlaneTilt property to Camera.ts, to tilt the projection plane about the X axis
  • Adding an applyVerticalCorrection method to Camera.ts to automatically tilt the projection plane so it compensates the camera pitch, and vertical lines appear vertical on the screen

I'll post on the forum a FYI detail of the maths

@CraigFeldspar
Copy link
Member Author

Playground : http://localhost:1338/Playground/index-local.html#L20FJ4#15

@CraigFeldspar CraigFeldspar marked this pull request as ready for review June 22, 2021 09:11
@sebavan sebavan requested a review from RaananW June 22, 2021 12:47
@sebavan sebavan merged commit e399cd4 into BabylonJS:master Jun 22, 2021
@thomlucc thomlucc mentioned this pull request Jan 11, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Popov72 Popov72 Popov72 left review comments

@sebavan sebavan sebavan approved these changes

@RaananW RaananW RaananW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@CraigFeldspar @RaananW @Popov72 @sebavan