From d4fb1c8bdebbb581ffc6e5ea286bec31f3d6bc42 Mon Sep 17 00:00:00 2001 From: Popov72 Date: Thu, 3 Nov 2022 21:10:11 +0100 Subject: [PATCH] Fix crash when calling moveAllFromScene if environmentTexture is present --- packages/dev/core/src/assetContainer.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/dev/core/src/assetContainer.ts b/packages/dev/core/src/assetContainer.ts index c6e5a6708be..5dcec138d7f 100644 --- a/packages/dev/core/src/assetContainer.ts +++ b/packages/dev/core/src/assetContainer.ts @@ -614,7 +614,7 @@ export class AssetContainer extends AbstractScene { } private _moveAssets(sourceAssets: T[], targetAssets: T[], keepAssets: T[]): void { - if (!sourceAssets) { + if (!sourceAssets || !targetAssets) { return; } @@ -649,7 +649,7 @@ export class AssetContainer extends AbstractScene { for (const key in this) { if (Object.prototype.hasOwnProperty.call(this, key)) { - (this)[key] = (this)[key] || (key === "environmentTexture" ? null : []); + (this)[key] = (this)[key] || (key === "_environmentTexture" ? null : []); this._moveAssets((this.scene)[key], (this)[key], (keepAssets)[key]); } }