Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set event.sourceEvent in ExecuteCodeAction callback for pointer triggers #13518

Conversation

docEdub
Copy link
Contributor

@docEdub docEdub commented Feb 9, 2023

When an ExecuteCodeAction is created with a pointer trigger, the callback's ActionEvent.sourceEvent member is set to undefined.

This change sets the callback's ActionEvent.sourceEvent member to the original event causing the action to be triggered.

Requested on forum: https://forum.babylonjs.com/t/action-enhancements/38043.

When an ExecuteCodeAction is created with a pointer trigger, the callback's ActionEvent.sourceEvent member is set to undefined.

This change sets the callback's ActionEvent.sourceEvent member to the original event causing the action to be triggered.
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 9, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 9, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 9, 2023

@docEdub docEdub marked this pull request as ready for review February 9, 2023 08:15
@RaananW RaananW merged commit 0a53e26 into BabylonJS:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants