Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript version 0 test version for playground #4706

Closed
wants to merge 6 commits into from
Closed

Typescript version 0 test version for playground #4706

wants to merge 6 commits into from

Conversation

NasimiAsl
Copy link
Contributor

No description provided.

@deltakosh
Copy link
Contributor

It is a reallllly good start :)
Some remarks:

  • The ts.js should not duplicate everything because it will be a nightmare to maintain. We should have a central index.js and a ts.js that contains only the changes needed for the TS to work
  • Not a big fan of the base scene.txt. I would not expect to create my own scene, etc... Perhaps we should just provide a simpler example like the one on the doc.babylonjs.com

@NasimiAsl
Copy link
Contributor Author

ok help me to finish that
what you suggest for ts.js?
and i like any simple scene

@deltakosh
Copy link
Contributor

Unfortunately I don't have that much time:(
Ideally just remove the code that is already in index.js and just keep the new function in TS.js

@deltakosh
Copy link
Contributor

Let me give a try I have a free hour :D

@deltakosh
Copy link
Contributor

I pushed it directly! Thanks a lot my friend

@deltakosh deltakosh closed this Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants