From ea30112e3e7f914a7674b6027b22895f6f570693 Mon Sep 17 00:00:00 2001 From: sebastien Date: Wed, 17 Oct 2018 22:59:00 +0200 Subject: [PATCH 1/2] Intro text for build error --- Tools/Gulp/gulpfile.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Tools/Gulp/gulpfile.js b/Tools/Gulp/gulpfile.js index 7129f146586..f25845c810e 100644 --- a/Tools/Gulp/gulpfile.js +++ b/Tools/Gulp/gulpfile.js @@ -357,10 +357,12 @@ gulp.task("typescript-compile", function() { //If this gulp task is running on travis, file the build! if (process.env.TRAVIS) { - tsResult.once("error", function() { - tsResult.once("finish", function() { + tsResult.once("error", function(e) { + tsResult.once("finish", function(ee) { console.log("Typescript compile failed"); - process.exit(1); + //process.exit(1); + + console.error(e);console.error(ee); }); }); } From 8c16bdbcb1762c0c98aa646cf16e8256b7ba5c40 Mon Sep 17 00:00:00 2001 From: sebastien Date: Wed, 17 Oct 2018 23:29:43 +0200 Subject: [PATCH 2/2] Fix Build --- Tools/Gulp/gulpfile.js | 32 ++++++++++++---------------- src/Cameras/XR/babylon.webXRInput.ts | 2 +- 2 files changed, 15 insertions(+), 19 deletions(-) diff --git a/Tools/Gulp/gulpfile.js b/Tools/Gulp/gulpfile.js index f25845c810e..12ebad17296 100644 --- a/Tools/Gulp/gulpfile.js +++ b/Tools/Gulp/gulpfile.js @@ -355,17 +355,13 @@ gulp.task("typescript-compile", function() { summarizeFailureOutput: true })); - //If this gulp task is running on travis, file the build! - if (process.env.TRAVIS) { - tsResult.once("error", function(e) { - tsResult.once("finish", function(ee) { - console.log("Typescript compile failed"); - //process.exit(1); - - console.error(e);console.error(ee); - }); + tsResult.once("error", function(err) { + tsResult.once("finish", function() { + console.log("Typescript compile failed"); + console.error(err); + process.exit(1); }); - } + }); return merge2([ tsResult.dts @@ -893,14 +889,13 @@ gulp.task("modules-compile", function() { .pipe(tsProject()); // If this gulp task is running on travis - if (process.env.TRAVIS) { - tsResult.once("error", function() { - tsResult.once("finish", function() { - console.log("Typescript compile failed"); - process.exit(1); - }); + tsResult.once("error", function(err) { + tsResult.once("finish", function() { + console.log("Typescript compile failed"); + console.error(err); + process.exit(1); }); - } + }); return merge2([ tsResult.dts @@ -1207,8 +1202,9 @@ gulp.task("tests-unit-transpile", function(done) { .pipe(tsProject()); tsResult.once("error", function() { - tsResult.once("finish", function() { + tsResult.once("finish", function(err) { console.log("Typescript compile failed"); + console.error(err); process.exit(1); }); }); diff --git a/src/Cameras/XR/babylon.webXRInput.ts b/src/Cameras/XR/babylon.webXRInput.ts index 3deb22113a4..d9eb11073ea 100644 --- a/src/Cameras/XR/babylon.webXRInput.ts +++ b/src/Cameras/XR/babylon.webXRInput.ts @@ -49,7 +49,7 @@ module BABYLON { public constructor(private helper: WebXRExperienceHelper) { this._frameObserver = helper._sessionManager.onXRFrameObservable.add(() => { if (!helper._sessionManager._currentXRFrame || !helper._sessionManager._currentXRFrame.getDevicePose) { - return false; + return; } var xrFrame = helper._sessionManager._currentXRFrame;