New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depth-of-field improvements #567

Merged
merged 4 commits into from Jun 9, 2015

Conversation

Projects
None yet
2 participants
@jahow
Contributor

jahow commented Jun 9, 2015

Hi and sorry for missing the 2.1 milestone! Here are a few improvements I had in mind for some time:

  • Improved the blur equation, which is now faithful to how optics work in real life
  • Added a randomization to the blur samples, smoothing out the artifacts when the blur was too strong
  • Added a 'darken' effect on parts which are out of focus
  • The pipeline is now compatible with a transparent background (previously when applying the pipeline a transparent background would have been redrawn black)
    Here is a picture of the DoF before this patch: http://i.imgur.com/Kf9u3et.png
    And after: http://i.imgur.com/JJ2J2FY.png

Note: documentation will have to be slightly updated.

@deltakosh

This comment has been minimized.

Show comment
Hide comment
@deltakosh

deltakosh Jun 9, 2015

Contributor

Can you update the doc then :)

Thank you for this great PR!

Contributor

deltakosh commented Jun 9, 2015

Can you update the doc then :)

Thank you for this great PR!

deltakosh added a commit that referenced this pull request Jun 9, 2015

@deltakosh deltakosh merged commit 345a9fa into BabylonJS:master Jun 9, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jahow jahow deleted the jahow:lens_vfx_patch branch Jul 10, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment