Changes to meshes transform baking and added flipFaces #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
Jun 23, 2015
jahow
changed the title
| data = this.getVerticesData(VertexBuffer.NormalKind); | ||
| temp = []; | ||
| var temp_normal = new Vector3(0, 0, 0); // this vector is used to normalize the newly transformed normal | ||
| for (index = 0; index < data.length; index += 3) { | ||
| Vector3.TransformNormal(Vector3.FromArray(data, index), transform).toArray(temp, index); |
There was a problem hiding this comment.
Normalizing does make sense! :-)
Doesn't this function already deliver a normal? You can simply add the normalize function between the TransformNormal and the toArray. Or did I miss something?
There was a problem hiding this comment.
You're absolutely right. I'll update the PR!
added 2 commits
Jun 23, 2015
|
Changed the way the normal is normalized (thanks Raanan), although I'm realizing that whether the normal vector is normalized or not doesn't change much the final render. But I guess we'll all sleep better if normals are normals ;) |
| public flipFaces(flipNormals: boolean = false): void { | ||
| var vertex_data = VertexData.ExtractFromMesh(this); | ||
|
|
||
| if (flipNormals) { |
There was a problem hiding this comment.
You should test for normal presence here
|
Hey can you rebase it? |
|
Nevermind..I'll merge it :D |
|
Oh ok, thanks! sorry I didn't do it in time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Added the following functions to the Mesh class:
bakeCurrentTransformIntoVertices(): computes the world matrix of the mesh, bake it in its vertices and then clears all transformflipFaces(flipNormals: boolean): inverse all the faces of the mesh, and optionally scales all the normals by -1Modified the following function:
bakeTransformIntoVertices(...): this function now makes sure that transformed normals are kept normalized, and flip the faces of the mesh if necessaryShould make mirroring meshes much easier!