[XR] Fix teleportation backwards movement #8855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebavan
approved these changes
Sep 2, 2020
| this._tmpRay.origin.copyFrom(this._tmpVector); | ||
| this._tmpRay.direction.set(0, this._xrSessionManager.scene.useRightHandedSystem ? 1 : -1, 0); | ||
| // This will prevent the user from "falling" to a lower platform! | ||
| // TODO - should this be a flag? 'allow falling to lower platforms'? |
There was a problem hiding this comment.
I like the flag approach but I do not have enough background to be a good judge :-) I let you chose
There was a problem hiding this comment.
This is more "dev freedom" that an actual needed feature :-)
I will put it on future features to implement.
|
I let you merge when ready and I ll create the nightly after |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Me: develop a feature.
User: "hey, this is not working"
Also me: "who developed this??? And how did it work so far?!?!?!"
TL;dr - fixed an issue with backwards movement in XR. It is now working as expected. Closing #8854