From 13ff06fc262e994a84c49b637e25788281323242 Mon Sep 17 00:00:00 2001 From: Cedric Guillemet <1312968+CedricGuillemet@users.noreply.github.com> Date: Tue, 8 Aug 2023 14:46:03 +0200 Subject: [PATCH 1/2] V8 withoutInspector --- Core/AppRuntime/Source/AppRuntime_V8.cpp | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Core/AppRuntime/Source/AppRuntime_V8.cpp b/Core/AppRuntime/Source/AppRuntime_V8.cpp index 789e1dfd..2e9beeb0 100644 --- a/Core/AppRuntime/Source/AppRuntime_V8.cpp +++ b/Core/AppRuntime/Source/AppRuntime_V8.cpp @@ -66,7 +66,10 @@ namespace Babylon void AppRuntime::RunEnvironmentTier(const char* executablePath) { // Create the isolate. - Module& module = Module::Initialize(executablePath); +#ifdef ENABLE_V8_INSPECTOR + Module& module = +#endif + Module::Initialize(executablePath); v8::Isolate::CreateParams create_params; create_params.array_buffer_allocator = v8::ArrayBuffer::Allocator::NewDefaultAllocator(); v8::Isolate* isolate = v8::Isolate::New(create_params); From e79cbcb2fc432d4a4fcc33868ada3c9f9ee405d7 Mon Sep 17 00:00:00 2001 From: Cedric Guillemet <1312968+CedricGuillemet@users.noreply.github.com> Date: Tue, 8 Aug 2023 14:46:50 +0200 Subject: [PATCH 2/2] spaces --- Core/AppRuntime/Source/AppRuntime_V8.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Core/AppRuntime/Source/AppRuntime_V8.cpp b/Core/AppRuntime/Source/AppRuntime_V8.cpp index 2e9beeb0..513f7530 100644 --- a/Core/AppRuntime/Source/AppRuntime_V8.cpp +++ b/Core/AppRuntime/Source/AppRuntime_V8.cpp @@ -69,7 +69,7 @@ namespace Babylon #ifdef ENABLE_V8_INSPECTOR Module& module = #endif - Module::Initialize(executablePath); + Module::Initialize(executablePath); v8::Isolate::CreateParams create_params; create_params.array_buffer_allocator = v8::ArrayBuffer::Allocator::NewDefaultAllocator(); v8::Isolate* isolate = v8::Isolate::New(create_params);