Collapsible Panel Docs Review #448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-excelsior
suggested changes
Apr 6, 2023
| | Property | Type | Default value | Logic | Data Binding | UI Setting | Description | | ||
| |---------------------------------|--------|---------------|--------------------|--------------|------------|-------------------------------------------------------| | ||
| | Title <br> `title` | *Text* | `Panel Title` | Title Logic | YES | YES | The logic to determine the title of the panel. | | ||
| | Title <br> `title` | *Text* | `Panel Title` | Title Logic | YES | YES | Sets the title for the panel. | |
Contributor
There was a problem hiding this comment.
Please, fix markup for table
| As you can see, once the page is loaded and the panel is expanded, elements added to the container are visible and fully functional: | ||
|
|
||
| <p align="center"> | ||
| <img src="./example-images/component_collapsible_panel_2.png" alt="preview_2" width="780"/> |
Contributor
There was a problem hiding this comment.
Rename images to something meaningful
| You can add any elements supported in the UI-Builder to the component by dragging-and-dropping them to the content area of the Collapsible Panel. Those elements can be text, images, and even other custom components. For instance, the example below contains two elements(**Text** and **Color Picker**) added to the Collapsible Panel: | ||
|
|
||
| <p align="center"> | ||
| <img src="./example-images/component_collapsible_panel_1.png" alt="preview_1" width="780"/> |
Contributor
There was a problem hiding this comment.
Use please meaningful alt messages, that are needed for accessibility(it voiced for blind people)
Comment on lines
+9
to
+19
| You can add any elements supported in the UI-Builder to the component by dragging-and-dropping them to the content area of the Collapsible Panel. Those elements can be text, images, and even other custom components. For instance, the example below contains two elements(**Text** and **Color Picker**) added to the Collapsible Panel: | ||
|
|
||
| <p align="center"> | ||
| <img src="./example-images/component_collapsible_panel_1.png" alt="preview_1" width="780"/> | ||
| </p> | ||
|
|
||
| As you can see, once the page is loaded and the panel is expanded, elements added to the container are visible and fully functional: | ||
|
|
||
| <p align="center"> | ||
| <img src="./example-images/component_collapsible_panel_2.png" alt="preview_2" width="780"/> | ||
| </p> |
Contributor
There was a problem hiding this comment.
Move it to examples section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.