Skip to content

Support EDNS#106

Merged
samuelwilliams merged 8 commits into
Badcow:support-ednsfrom
yeganemehr:support-edns
Feb 8, 2022
Merged

Support EDNS#106
samuelwilliams merged 8 commits into
Badcow:support-ednsfrom
yeganemehr:support-edns

Conversation

@yeganemehr

@yeganemehr yeganemehr commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

Add support for handling OPT Rdata and these EDNS Option:

  • COOKIE
  • TCP KEEPALIVE
  • CLIENT SUBNET

@samuelwilliams

samuelwilliams commented Jan 29, 2022

Copy link
Copy Markdown
Contributor

Thank you @yeganemehr lots of good work has been done here. I have merged your pull request into a separate branch support-edns.
There are a couple of issues:

  • Class Badcow\DNS\Edns\Option\UnknownOption contains 2 abstract methods and must therefore be declared abstract or implement the remaining methods - UnknownOption has not implemented GetName or GetNameCode from the interface.
  • You need to test this new functionality a bit more. I would say test each of the new options and the UnknownOption.

I will implement your changes into V4.2 once they are fixed up a little.

@yeganemehr

yeganemehr commented Feb 7, 2022

Copy link
Copy Markdown
Contributor Author

Hi @samuelwilliams
Your work in this project is brilliant and I'm happy to be part of it!

About problems you were right; There was some problems which found by unit tests and phpstan.
Please check it out again and if still something that I missed, let me know.

@samuelwilliams samuelwilliams changed the base branch from master to support-edns February 8, 2022 10:59
@samuelwilliams samuelwilliams merged commit 478e359 into Badcow:support-edns Feb 8, 2022
samuelwilliams added a commit that referenced this pull request Feb 11, 2022
@samuelwilliams @yeganemehr
Support edns (#108)
fa9ac1d 
* Fix PHPStan errors.

* Support EDNS (#106)

* Use self::NAME instead of static::CODE

* Remove duplicate index and fix phpdoc

* Fix using of undefined variable

* implementing two missing methods from OptionInterface

* Fix phpdoc

* add some tests for Edns and OPT Rdata

Co-authored-by: Sam Williams <samuel.williams8@gmail.com>

* Fix merge issues.

* CS fixes.

* Updated changelog.

Co-authored-by: Amir.h Yeganemehr <yeganemehr@yahoo.com>
@yeganemehr yeganemehr deleted the support-edns branch February 13, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yeganemehr @samuelwilliams