Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scrape all token balances for multi sig wallets #25

Merged
merged 8 commits into from Jan 24, 2022
Merged

scrape all token balances for multi sig wallets #25

merged 8 commits into from Jan 24, 2022

Conversation

jalbrekt85
Copy link
Collaborator

@jalbrekt85 jalbrekt85 commented Jan 21, 2022

script for #23

- brownie-config updated so that api keys can be referenced from brownie.config inside scripts
- uses ethplorer api to get all tokens and their balances
- token_address and its value are saved into csv. not sure if any other data is needed

  • scrape function now adheres to the airdrop format
  • queries token balances from treasury_tokens instead of external api
  • specify receiving address
  • progress bar and table

script can be run through command line to scrape balances with supplied address:
brownie run scripts/gnosis/scrape_tokens.py scrape <address> <receiver>

scripts/issue/23/scrape_tokens.py Outdated Show resolved Hide resolved
scripts/issue/23/scrape_tokens.py Outdated Show resolved Hide resolved
scripts/issue/23/scrape_tokens.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@gosuto-inzasheru gosuto-inzasheru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • good use of Decimal
  • i asked a dev on gnosis discord (message url) about the decimals column being needed in the csv, but from testing current output in the app it doesnt seem like it poses a problem to include it.
  • i didnt know about Progress; nice!

@gosuto-inzasheru gosuto-inzasheru requested a review from a team January 24, 2022 10:06
Copy link
Collaborator

@petrovska-petro petrovska-petro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very neat usage of Table and Progress 💪

Tested with cmd:

 brownie run gnosis/scrape_tokens.py scrape 0xB65cef03b9B89f99517643226d76e286ee999e77 0x042B32Ac6b453485e357938bdC38e0340d4b9276

Verify that generates csv following gnosis csv airdrop format.

@gosuto-inzasheru
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants