BAH 1109, BAH 1106 | Shriram , Gopi , Rakesh , Aakash , Som | Zipping and importing AddressHierarchy & OfflineConcepts Data in BahmniConnect & Selective Sync Strategy #22
Conversation
…and offline concepts and importing them on page load.
BAH-1109 | Rakesh, Gopi | Fix dist folder not showing syndatrules folder and its content on build BAH-1109 | Rakesh, Gopi | Fix Filter issue BAH-1109 | Gopi,Rakesh | Added an Alert to check whether user connected to Network or not
gopikrishna-yaramothu
changed the title
gopikrishna-yaramothu
force-pushed
the
BAH-1109-BAH-1106
branch
from
6224711
to
b1830eb
Compare
gopikrishna-yaramothu
force-pushed
the
BAH-1109-BAH-1106
branch
from
b1830eb
to
67a45b7
Compare
| var getAddressHierarchyDataForFiles = function (fileNames, count, eventLogUuid, dbName) { | ||
| if (count !== fileNames.length) { | ||
| return $http.get(Bahmni.Common.Constants.preprocessedAddressHierarchyUrl + fileNames[count]).then(function (response) { | ||
| updatePendingEventsCount("addressHierarchy", response.data.addressHierarchy.length); |
There was a problem hiding this comment.
@gopikrishna-yaramothu can we have the constants defined instead of hardcoding the names here like "addressHierarchy", "eventLogCategories", "forms", "offline-concepts"..etc
| headers: { "Accept": "application/text", "Content-Type": "text/plain" } | ||
| }).then((response) => { | ||
| let value = response.data; | ||
| if (value.includes("SelectiveSyncStrategy")) { $scope.isSelectiveSyncStrategy = true; } |
There was a problem hiding this comment.
@gopikrishna-yaramothu try to use constants instead of hardcoded text here
|
@gopikrishna-yaramothu @sombhattacharyya1983 test coverage is not as expected for the newly implemented code. Requesting you to add more test cases. Thanks ! |
…ni-connect into BAH-1109-BAH-1106
| var verifySelectiveSync = function () { | ||
| $http.get('/openmrs/ws/rest/v1/eventlog/filter/globalProperty/', { | ||
| method: "GET", | ||
| params: { q: 'bahmniOfflineSync.strategy' }, |
There was a problem hiding this comment.
this shouldn't be part of controller. Do we have any service that it talks to. If yes, we can move the code to the service file @gopikrishna-yaramothu
There was a problem hiding this comment.
We didn't have any service that will do the needful Bindu. if it's better to use service we will create a new service . please suggest us .
There was a problem hiding this comment.
@binduak
This has been fixed
| var verifySelectiveSync = function () { | ||
| $http.get('/openmrs/ws/rest/v1/eventlog/filter/globalProperty/', { | ||
| method: "GET", | ||
| params: { q: 'bahmniOfflineSync.strategy' }, |
There was a problem hiding this comment.
@gopikrishna-yaramothu same as mentioned above
There was a problem hiding this comment.
@binduak
this has been fixed
|
@gopikrishna-yaramothu the below files doesn't have any new test cases added |
|
|
Description
As per existing functionality, during initial sync process( I.e. enable new Tablet/Device to use BAHMNI in fields i.e. Offline BAHMNI) , all offline concepts, address hierarchy and patient information for a specific login location is being synced from BAHMNI server to connect device. This is time consuming process and take around 8 to 10 hours to complete the initial sync. As part of this story card, need to modify the existing workflow of the Initial sync process for initial sync performance improvement.
Contributors ::
@shriram-k
@Aakash16
@rakesh-1010
@gopikrishnayaramothu
@sombhattacharyya1983