New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide play icon when there's no file to play #42

Merged
merged 1 commit into from Mar 14, 2017

Conversation

2 participants
@fri-sch
Contributor

fri-sch commented Feb 3, 2017

Another small change to prevent users from trying to play a sermon if there's no audio or video attached.
In my opinion it's best to not show the play icon at all.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Feb 5, 2017

Owner

That looks fine on first glance. I will have to test it before merging and I need a bit of time for that.

Owner

Bakual commented Feb 5, 2017

That looks fine on first glance. I will have to test it before merging and I need a bit of time for that.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Feb 12, 2017

Owner

I looked at this a bit more closely and I think it's done a bit to generic. The "case 0" one would still make sense even without any files as it is just a link to the detailpage. So that check should go into each case, and likely as well be done for the title link.

On a sidenote I saw that the "Control Player" is quite broken when there are sermons without any files as it will select the wrong entry in the playlist. I need to check that as well.

Owner

Bakual commented Feb 12, 2017

I looked at this a bit more closely and I think it's done a bit to generic. The "case 0" one would still make sense even without any files as it is just a link to the detailpage. So that check should go into each case, and likely as well be done for the title link.

On a sidenote I saw that the "Control Player" is quite broken when there are sermons without any files as it will select the wrong entry in the playlist. I need to check that as well.

@fri-sch

This comment has been minimized.

Show comment
Hide comment
@fri-sch

fri-sch Feb 12, 2017

Contributor

I guess you're right. This solution was more like a quick fix.

Regarding the playlist selection, I have a commit in my repo to work around this in the JWPlayer plugin, but it is definitely not ready for general use: fri-sch@2723fee

Contributor

fri-sch commented Feb 12, 2017

I guess you're right. This solution was more like a quick fix.

Regarding the playlist selection, I have a commit in my repo to work around this in the JWPlayer plugin, but it is definitely not ready for general use: fri-sch@2723fee

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Mar 14, 2017

Owner

I'm going to merge this and adjust as needed afterwards.

Owner

Bakual commented Mar 14, 2017

I'm going to merge this and adjust as needed afterwards.

@Bakual Bakual merged commit 9da1b3a into Bakual:master Mar 14, 2017

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Mar 14, 2017

Owner

Btw: 90e7e06 should fix the issue with the playlist selection. Apparently JW Player just ignores a pic now for the playlist, that used to work in earlier versions. I now just use a blank.mp3 file instead of the picture to create a dummy playlist entry.

Owner

Bakual commented Mar 14, 2017

Btw: 90e7e06 should fix the issue with the playlist selection. Apparently JW Player just ignores a pic now for the playlist, that used to work in earlier versions. I now just use a blank.mp3 file instead of the picture to create a dummy playlist entry.

@Bakual

This comment has been minimized.

Show comment
Hide comment
@Bakual

Bakual Mar 14, 2017

Owner

40333f3 should fix the remaining issues.
Thanks!

Owner

Bakual commented Mar 14, 2017

40333f3 should fix the remaining issues.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment