Make build reproducible #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can be done without any code modification as version 1.1.1 is API and ABI compatible with version 1.1.0 https://wiki.openssl.org/index.php/TLS1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort [0], we noticed
that libzorpll could not be built reproducibly. This is due to the use
of uname to set ZORPLIB_ENABLE_STACKDUMP based on build
architecture in a header file [1]. uname is known to be unreliable
especially in containers. If you have any questions or concerns about
this, please feel free to comment/critique. Happy to help in any way!
Also, noticed the use of date command for CURRDATE. But it seems
that CURRDATE is not being used anywhere. Dates are also a known
source of unreproducibility. If CURRDATE is ever used, please take
a look at SOURCE_DATE_EPOCH [2] instead to ensure reproducibility.
[0] https://reproducible-builds.org/
[1] https://tests.reproducible-builds.org/debian/rb-pkg/unstable/i386/libzorpll.html
[2] https://reproducible-builds.org/specs/source-date-epoch/