Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make JSON RPC API Command Methods Case Insensitive #1016

Closed
schwede opened this issue Jun 12, 2019 · 0 comments
Closed

Make JSON RPC API Command Methods Case Insensitive #1016

schwede opened this issue Jun 12, 2019 · 0 comments
Labels
Milestone

Comments

@schwede
Copy link
Contributor

@schwede schwede commented Jun 12, 2019

Is your feature request related to a problem? Please describe.
When using the json-rpc api, command request were being rejected as 'unauthorized methods'. I realized that we were sending "Cmd" instead of "cmd" to send commands.

Describe the solution you'd like
Since these names are unique, I would like the api method whitelist to allow different casing. I realize that it is documented with a reference to this file (https://github.com/BallAerospace/COSMOS/blob/master/lib/cosmos/tools/cmd_tlm_server/api.rb) but allowing case variations would make the api a little more friendly to use.

schwede added a commit to schwede/COSMOS that referenced this issue Sep 5, 2019
jmthomas added a commit that referenced this issue Nov 6, 2019
#1016 Make rpc function names case-insensitive
@jmthomas jmthomas closed this Nov 6, 2019
@ryanmelt ryanmelt added this to the v4.4.1 milestone Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.