New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sound to COSMOS alerts #133

Closed
jmthomas opened this Issue May 19, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@jmthomas
Member

jmthomas commented May 19, 2015

Our users would like to have alert sounds when Script dialogs popup to notify the user during long script executions. I also wonder if yellow and/or red limit violations should have some sort of alert sound. We already have a "production" flag in the server which could potentially be used to enable sound alerts as well. However, due to the potentially annoyance of sound maybe there is a separate flag to explicitly disable sound?

I think overriding the Qt::MessageBox methods would allow us to add sound to popups relatively easily.

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball May 19, 2015

Member

You can make this a setting in system.txt. Default off.

Member

ryanatball commented May 19, 2015

You can make this a setting in system.txt. Default off.

jmthomas pushed a commit that referenced this issue May 19, 2015

ryanatball added a commit that referenced this issue May 19, 2015

jmthomas added a commit that referenced this issue May 19, 2015

Merge pull request #134 from BallAerospace/add_sound
Add sound option to System and enable sound in alerts #133
@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball May 20, 2015

Member

closed by pull request #134

Member

ryanatball commented May 20, 2015

closed by pull request #134

@ryanatball ryanatball closed this May 20, 2015

@ryanatball ryanatball added the feature label Jun 11, 2015

@ryanatball ryanatball modified the milestone: v3.5.0 Jun 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment