Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all reserved item names from system cmd meta #1438

Merged
4 commits merged into from Jan 24, 2022
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jan 22, 2022

Discussion on #1424

@ghost ghost self-requested a review January 22, 2022 00:07
@codecov
Copy link

codecov bot commented Jan 22, 2022

Codecov Report

Merging #1438 (667ba30) into cosmos4 (c3ec0d2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           cosmos4    #1438   +/-   ##
========================================
  Coverage    78.66%   78.66%           
========================================
  Files          165      165           
  Lines        15722    15722           
========================================
  Hits         12367    12367           
  Misses        3355     3355           
Impacted Files Coverage Δ
lib/cosmos/system/system.rb 88.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3ec0d2...667ba30. Read the comment docs.

@ghost ghost merged commit f53d12e into cosmos4 Jan 24, 2022
@ghost ghost deleted the system_cmd_meta branch January 24, 2022 17:25
@ghost ghost added this to the v4.5.2 milestone Jan 28, 2022
@ghost ghost added bug cosmos4 labels Jan 28, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant