Need support for additional non-standard serial baud rates #146

Closed
shaydr opened this Issue Jun 2, 2015 · 2 comments

Comments

Projects
None yet
2 participants
@shaydr
Contributor

shaydr commented Jun 2, 2015

I have a serial device capable of supporting 921.6Kbps however the current implementation of win32_serial_driver.rb checks for the requested baud_rate to be in the Win32::BAUD_RATES array and then raises an exception if not found.

The DCB structure supports arbitrary baud rates. I have tested a modification to the Win32::BAUD_RATES array where the addition of 921.6Kbps works with a target device.

Suggestions for Resolution

  • Add Api to add additional supported rates programmically from target interface definition
  • Ignore the check
  • Add the missing non-standard rates [230400, 460800, 500000, 576000, 921600, 1000000, 1152000, 1500000, 2000000, 3000000, 3500000, 4000000].

I think adding additional rates is the best option, additional rates not expected to be added anytime soon.

_NOTE:_ the posix_serial_driver uses termios and it looks like 921600 is defined on modern linux distros and in the ruby-termios package

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball Jun 3, 2015

Member

Dan - Are you planning on implementing this or should I?

Member

ryanatball commented Jun 3, 2015

Dan - Are you planning on implementing this or should I?

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball Jun 10, 2015

Member

closed by pull request #149

Member

ryanatball commented Jun 10, 2015

closed by pull request #149

@ryanatball ryanatball closed this Jun 10, 2015

@ryanatball ryanatball modified the milestone: v3.5.0 Jun 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment