Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure read conversion cache cannot be cleared mid-use #16

Closed
ryanatball opened this issue Jan 14, 2015 · 2 comments
Closed

Ensure read conversion cache cannot be cleared mid-use #16

ryanatball opened this issue Jan 14, 2015 · 2 comments
Labels
bug
Milestone

Comments

@ryanatball
Copy link
Member

@ryanatball ryanatball commented Jan 14, 2015

Ensure read conversion cache cannot be cleared mid-use. A poorly timed clear could lead to nil being returned instead of the converted value.

@jmthomas
Copy link
Member

@jmthomas jmthomas commented Jan 16, 2015

We've noticed data drop outs in telemetry (things go to 0) which I think might also be a result of returning a nil. If you could work this I think we want this change ASAP.

ryanatball added a commit that referenced this issue Jan 23, 2015
ryanatball added a commit that referenced this issue Jan 23, 2015
ryanatball added a commit that referenced this issue Jan 26, 2015
ryanatball added a commit that referenced this issue Jan 27, 2015
ryanatball added a commit that referenced this issue Jan 27, 2015
ryanatball added a commit that referenced this issue Jan 27, 2015
@ryanatball
Copy link
Member Author

@ryanatball ryanatball commented Jan 27, 2015

Resolved by pull request #24

@ryanatball ryanatball closed this Jan 27, 2015
@ryanatball ryanatball added the bug label Feb 20, 2015
@ryanatball ryanatball added this to the v3.1.1 milestone Feb 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.