Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits Monitor show green for blue limits items #184

Closed
jmthomas opened this issue Aug 5, 2015 · 5 comments
Closed

Limits Monitor show green for blue limits items #184

jmthomas opened this issue Aug 5, 2015 · 5 comments
Labels
Milestone

Comments

@jmthomas
Copy link
Member

@jmthomas jmthomas commented Aug 5, 2015

A user requested a feature where Limits Monitor would show items close to their yellow limits. Perhaps another tab to show things within a percentage of the yellow limit. This helps with situational awareness to prevent an actual yellow limit which could trigger required operator actions.

@jmthomas jmthomas added the feature label Aug 5, 2015
@ryanatball
Copy link
Member

@ryanatball ryanatball commented Aug 5, 2015

The point of yellow limits is to give you warning before the red limits. For what they are wanting they should be using a blue limits and having green indicate they are getting closer to yellow. I think this should be rejected.

@jmthomas
Copy link
Member Author

@jmthomas jmthomas commented Aug 6, 2015

I agree. I was looking through the code and this would require evaluating EVERY item all the time which we currently do not do. We rely on event driven notifications on when something goes out of limits and then just monitor those items. It would destroy the performance.

@jmthomas jmthomas closed this Aug 6, 2015
@jmthomas jmthomas reopened this Aug 6, 2015
@jmthomas
Copy link
Member Author

@jmthomas jmthomas commented Aug 6, 2015

So if they implement operational blue limits they still wouldn't know which items are close to yellow because limits monitor doesn't display green limits. Perhaps the solution is for limits monitor to display green limits? Perhaps on a different tab? At that point maybe it displays blue too? Then it would have everything.

@ryanatball
Copy link
Member

@ryanatball ryanatball commented Aug 6, 2015

Perhaps, but only if the item has blue limits defined

@jmthomas jmthomas changed the title Limits Monitor show items close to out of limits Limits Monitor show green for blue limits items Aug 7, 2015
@jmthomas
Copy link
Member Author

@jmthomas jmthomas commented Apr 29, 2016

PR #284

@jmthomas jmthomas closed this May 3, 2016
@ryanatball ryanatball modified the milestone: v3.8.1 May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.