Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config Option or Increase Tcpip Interface Timeout to TlmGrapher #233

Closed
aaronlyons opened this issue Dec 15, 2015 · 4 comments
Closed

Add Config Option or Increase Tcpip Interface Timeout to TlmGrapher #233

aaronlyons opened this issue Dec 15, 2015 · 4 comments
Assignees
Labels
Milestone

Comments

@aaronlyons
Copy link
Contributor

@aaronlyons aaronlyons commented Dec 15, 2015

Currently TlmGrapher defaults the real time plotting TcpipClientInterface connection to CTS with a 10.0 second timeout in TabbedPlotsRealtimeThread (tabbed_plots_realtime_thread.cpp:22). This works fine for most interfaces, however when real plotting from very slow interfaces (e.g. once per minute updates over days) this timeout causes many connect/disconnect timeouts to the CTS and misses data updates.

Recommend one of the following:

  1. Increase the default or remove the timeout for this interface
  2. Add interface timeout option as a configuration parameter to TlmGrapher

Option 2 would involve adding a default configuration file for the TlmGrapher tool (doesn't exist yet) and defining the configuration option.

@ryanatball ryanatball added the feature label Dec 22, 2015
@jmthomas
Copy link
Member

@jmthomas jmthomas commented Aug 29, 2016

@ryanatball should we just eliminate the timeout? You still get "Connection to COSMOS Server Lost" and "Connection to COSMOS Server Failed : RuntimeError : Connect timeout" even without the timeout. Seems like we can eliminate it.

@ryanatball
Copy link
Member

@ryanatball ryanatball commented Sep 9, 2016

Reliable TCP connections require a timeout. Otherwise the connection can break and the break can never be detected. We should add the configuration option

@donaldatball
Copy link
Collaborator

@donaldatball donaldatball commented May 5, 2017

Note that I added a page to the website to document the TlmGrapher configuration options as part of the work done under this ticket. I accidentally referenced ticket #189 a couple times while checking in stuff against the website branch. Sorry.

donaldatball added a commit that referenced this issue May 8, 2017
re #233 Add CTS timeout configuration option to TlmGrapher
@donaldatball
Copy link
Collaborator

@donaldatball donaldatball commented May 8, 2017

Closed with d6bf42e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.