Add Config Option or Increase Tcpip Interface Timeout to TlmGrapher #233

Closed
aaronlyons opened this Issue Dec 15, 2015 · 4 comments

Comments

Projects
None yet
4 participants
@aaronlyons
Collaborator

aaronlyons commented Dec 15, 2015

Currently TlmGrapher defaults the real time plotting TcpipClientInterface connection to CTS with a 10.0 second timeout in TabbedPlotsRealtimeThread (tabbed_plots_realtime_thread.cpp:22). This works fine for most interfaces, however when real plotting from very slow interfaces (e.g. once per minute updates over days) this timeout causes many connect/disconnect timeouts to the CTS and misses data updates.

Recommend one of the following:

  1. Increase the default or remove the timeout for this interface
  2. Add interface timeout option as a configuration parameter to TlmGrapher

Option 2 would involve adding a default configuration file for the TlmGrapher tool (doesn't exist yet) and defining the configuration option.

@ryanatball ryanatball added the feature label Dec 22, 2015

@jmthomas

This comment has been minimized.

Show comment
Hide comment
@jmthomas

jmthomas Aug 29, 2016

Member

@ryanatball should we just eliminate the timeout? You still get "Connection to COSMOS Server Lost" and "Connection to COSMOS Server Failed : RuntimeError : Connect timeout" even without the timeout. Seems like we can eliminate it.

Member

jmthomas commented Aug 29, 2016

@ryanatball should we just eliminate the timeout? You still get "Connection to COSMOS Server Lost" and "Connection to COSMOS Server Failed : RuntimeError : Connect timeout" even without the timeout. Seems like we can eliminate it.

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball Sep 9, 2016

Member

Reliable TCP connections require a timeout. Otherwise the connection can break and the break can never be detected. We should add the configuration option

Member

ryanatball commented Sep 9, 2016

Reliable TCP connections require a timeout. Otherwise the connection can break and the break can never be detected. We should add the configuration option

@donaldatball

This comment has been minimized.

Show comment
Hide comment
@donaldatball

donaldatball May 5, 2017

Collaborator

Note that I added a page to the website to document the TlmGrapher configuration options as part of the work done under this ticket. I accidentally referenced ticket #189 a couple times while checking in stuff against the website branch. Sorry.

Collaborator

donaldatball commented May 5, 2017

Note that I added a page to the website to document the TlmGrapher configuration options as part of the work done under this ticket. I accidentally referenced ticket #189 a couple times while checking in stuff against the website branch. Sorry.

donaldatball added a commit that referenced this issue May 8, 2017

Merge pull request #440 from BallAerospace/tlm_grapher_timeout_option
re #233 Add CTS timeout configuration option to TlmGrapher
@donaldatball

This comment has been minimized.

Show comment
Hide comment
@donaldatball

donaldatball May 8, 2017

Collaborator

Closed with d6bf42e

Collaborator

donaldatball commented May 8, 2017

Closed with d6bf42e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment