Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get buffer from commands #254

Closed
planteen opened this issue Feb 16, 2016 · 2 comments
Closed

Get buffer from commands #254

planteen opened this issue Feb 16, 2016 · 2 comments
Labels
Milestone

Comments

@planteen
Copy link
Contributor

@planteen planteen commented Feb 16, 2016

Add a feature to allow get_cmd_value() API to pull the value of a command buffer by adding another virtual parameter called INTERFACE_BUFFER.

For example:

cmd("INST SETPARAMS with VALUE1 1, VALUE2 2, VALUE3 3, VALUE4 4, VALUE5 5")
buf = get_cmd_value("INST", "SETPARAMS", "INTERFACE_BUFFER")
buf.unpack("C*").each do |c|
  puts "#{c.to_s(16)}"
end
@planteen planteen changed the title Get buffer from get_cmd_value Get buffer from commands Mar 8, 2016
@planteen
Copy link
Contributor Author

@planteen planteen commented Mar 8, 2016

Based on comments from Ryan, change to separate function rather than virtual parameter to get_cmd_value() and add equivalent functionality for telemetry.

For example:

cmd("INST SETPARAMS with VALUE1 3")
x = get_cmd_buffer("INST", "SETPARAMS")
y = get_tlm_buffer("INST", "ADCS")
@ryanatball
Copy link
Member

@ryanatball ryanatball commented Mar 8, 2016

Closed by pull request #263

@ryanatball ryanatball closed this Mar 8, 2016
@ryanatball ryanatball added the feature label Mar 8, 2016
@ryanatball ryanatball modified the milestone: v3.8.1 May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.