Get buffer from commands #254

Closed
planteen opened this Issue Feb 16, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@planteen
Contributor

planteen commented Feb 16, 2016

Add a feature to allow get_cmd_value() API to pull the value of a command buffer by adding another virtual parameter called INTERFACE_BUFFER.

For example:

cmd("INST SETPARAMS with VALUE1 1, VALUE2 2, VALUE3 3, VALUE4 4, VALUE5 5")
buf = get_cmd_value("INST", "SETPARAMS", "INTERFACE_BUFFER")
buf.unpack("C*").each do |c|
  puts "#{c.to_s(16)}"
end

@planteen planteen changed the title from Get buffer from get_cmd_value to Get buffer from commands Mar 8, 2016

@planteen

This comment has been minimized.

Show comment
Hide comment
@planteen

planteen Mar 8, 2016

Contributor

Based on comments from Ryan, change to separate function rather than virtual parameter to get_cmd_value() and add equivalent functionality for telemetry.

For example:

cmd("INST SETPARAMS with VALUE1 3")
x = get_cmd_buffer("INST", "SETPARAMS")
y = get_tlm_buffer("INST", "ADCS")
Contributor

planteen commented Mar 8, 2016

Based on comments from Ryan, change to separate function rather than virtual parameter to get_cmd_value() and add equivalent functionality for telemetry.

For example:

cmd("INST SETPARAMS with VALUE1 3")
x = get_cmd_buffer("INST", "SETPARAMS")
y = get_tlm_buffer("INST", "ADCS")
@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball Mar 8, 2016

Member

Closed by pull request #263

Member

ryanatball commented Mar 8, 2016

Closed by pull request #263

@ryanatball ryanatball closed this Mar 8, 2016

@ryanatball ryanatball added the feature label Mar 8, 2016

@ryanatball ryanatball modified the milestone: v3.8.1 May 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment