Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap Qt::Application.instance in main_thread #273

Closed
jmthomas opened this issue Mar 28, 2016 · 0 comments
Closed

Wrap Qt::Application.instance in main_thread #273

jmthomas opened this issue Mar 28, 2016 · 0 comments
Assignees
Labels
bug
Milestone

Comments

@jmthomas
Copy link
Member

@jmthomas jmthomas commented Mar 28, 2016

There are two potential places where we use Qt::Application.instance outside GUI context and both are in top_level.rb: run_process_check_output and handle_fatal_exception. I've actually run into a crash during handle_fatal_exception which is bad because then you lose the original exception information.

@jmthomas jmthomas added the bug label Mar 28, 2016
@ryanatball ryanatball modified the milestone: v3.8.1 May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.