Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_tolerance should enforce a positive tolerance #288

Closed
jmthomas opened this issue Apr 27, 2016 · 1 comment
Closed

check_tolerance should enforce a positive tolerance #288

jmthomas opened this issue Apr 27, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@jmthomas
Copy link
Member

@jmthomas jmthomas commented Apr 27, 2016

Just call absolute value on the tolerance passed in to prevent accidental user error

@jmthomas jmthomas added the feature label Apr 29, 2016
@jmthomas jmthomas self-assigned this Apr 29, 2016
@jmthomas jmthomas closed this Apr 29, 2016
@jmthomas
Copy link
Member Author

@jmthomas jmthomas commented Apr 29, 2016

See pull request #289

@ryanatball ryanatball modified the milestone: v3.8.1 May 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.