check_tolerance should enforce a positive tolerance #288

Closed
jmthomas opened this Issue Apr 27, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@jmthomas
Member

jmthomas commented Apr 27, 2016

Just call absolute value on the tolerance passed in to prevent accidental user error

@jmthomas jmthomas added the feature label Apr 29, 2016

@jmthomas jmthomas self-assigned this Apr 29, 2016

@jmthomas jmthomas closed this Apr 29, 2016

@jmthomas

This comment has been minimized.

Show comment
Hide comment
@jmthomas

jmthomas Apr 29, 2016

Member

See pull request #289

Member

jmthomas commented Apr 29, 2016

See pull request #289

@ryanatball ryanatball modified the milestone: v3.8.1 May 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment