Units applied after a read_conversion that returns a string modifies cached conversion value #293

Closed
ryanatball opened this Issue May 4, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@ryanatball
Member

ryanatball commented May 4, 2016

This can lead to the units being appended to the cached value repeatedly.

Packet#apply_format_string_and_units() should clone the string before modifying it or not use the << operator.

@ryanatball ryanatball added the bug label May 4, 2016

@ryanatball ryanatball closed this in 2552bf5 May 5, 2016

ryanatball added a commit that referenced this issue May 5, 2016

Merge pull request #297 from BallAerospace/fix_read_conversion_cache_…
…values_modified_by_units


closes #293. Protect read conversion cache values

@ryanatball ryanatball modified the milestone: v3.8.1 May 12, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment