New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COSMOS Global Time Zone Setting (Local/UTC) #347

Closed
ryanatball opened this Issue Oct 19, 2016 · 5 comments

Comments

Projects
None yet
2 participants
@ryanatball
Member

ryanatball commented Oct 19, 2016

System.txt should support a time zone keyword to specify if COSMOS time choosers should expect local times or UTC times. (Currently it is local times)

@ryanatball ryanatball added the feature label Oct 19, 2016

@donaldatball donaldatball self-assigned this May 17, 2017

@donaldatball

This comment has been minimized.

Show comment
Hide comment
@donaldatball

donaldatball May 18, 2017

Collaborator

@ryanatball Just to make sure I understand the intent... when you say "time choosers", I'm thinking of the calendar dialogs that are used to select times for TlmExtractor. Is that what you had in mind, or am I thinking of the wrong thing?

Collaborator

donaldatball commented May 18, 2017

@ryanatball Just to make sure I understand the intent... when you say "time choosers", I'm thinking of the calendar dialogs that are used to select times for TlmExtractor. Is that what you had in mind, or am I thinking of the wrong thing?

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball May 18, 2017

Member

Yes, the time chooser boxes like in TlmExtractor. This should also affect anywhere time is displayed as well though.

Member

ryanatball commented May 18, 2017

Yes, the time chooser boxes like in TlmExtractor. This should also affect anywhere time is displayed as well though.

@donaldatball

This comment has been minimized.

Show comment
Hide comment
@donaldatball

donaldatball May 18, 2017

Collaborator

@ryanatball Ok, gotcha. So, for example, when I load a log file in Replay, it shows the start, current, and end times-- those would display in local/UTC depending on this setting as well, right? Do you think it'd be worth displaying the UTC offset (or UTC) wherever times are shown to make this more obvious? Something like what the default Time class does?

irb(main):001:0> Time.now
=> 2017-05-18 10:20:08 -0600
irb(main):002:0> Time.now.utc
=> 2017-05-18 16:20:13 UTC

Collaborator

donaldatball commented May 18, 2017

@ryanatball Ok, gotcha. So, for example, when I load a log file in Replay, it shows the start, current, and end times-- those would display in local/UTC depending on this setting as well, right? Do you think it'd be worth displaying the UTC offset (or UTC) wherever times are shown to make this more obvious? Something like what the default Time class does?

irb(main):001:0> Time.now
=> 2017-05-18 10:20:08 -0600
irb(main):002:0> Time.now.utc
=> 2017-05-18 16:20:13 UTC

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball May 18, 2017

Member

I would be ok with indicating the offset in some fashion.

Member

ryanatball commented May 18, 2017

I would be ok with indicating the offset in some fashion.

donaldatball added a commit that referenced this issue May 19, 2017

donaldatball added a commit that referenced this issue May 23, 2017

donaldatball added a commit that referenced this issue May 23, 2017

Merge pull request #457 from BallAerospace/system_time_zone
re #347 Add a system-level keyword to specify that COSMOS should glob…
@donaldatball

This comment has been minimized.

Show comment
Hide comment
@donaldatball

donaldatball May 23, 2017

Collaborator

Closed with b2dffdd

Also added the keyword to the website.

Collaborator

donaldatball commented May 23, 2017

Closed with b2dffdd

Also added the keyword to the website.

@ryanatball ryanatball modified the milestone: v4.0.0 Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment