Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize cmd() to not build commands twice #349

Closed
ryanatball opened this issue Nov 2, 2016 · 1 comment
Closed

Optimize cmd() to not build commands twice #349

ryanatball opened this issue Nov 2, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@ryanatball
Copy link
Member

@ryanatball ryanatball commented Nov 2, 2016

Currently commands are built once for the hazardous check, and again to actually send. This should be optimized to only build the command once.

@jmthomas jmthomas self-assigned this Nov 14, 2016
jmthomas pushed a commit that referenced this issue Nov 14, 2016
ryanatball added a commit that referenced this issue Nov 28, 2016
#349 Only build command once and then check hazardous state
@jmthomas
Copy link
Member

@jmthomas jmthomas commented Nov 29, 2016

Closed by #349

@jmthomas jmthomas closed this Nov 29, 2016
@ryanatball ryanatball modified the milestone: v3.8.3 Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.