New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add raw stream preamble and postamble data to "View Raw" #360

Closed
jmthomas opened this Issue Nov 17, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@jmthomas
Member

jmthomas commented Nov 17, 2016

Currently the View Raw feature in the Server shows the raw packet data. However if the data stream adds or removes data this doesn't show up. The only way to know about such preamble or postamble data is to enable raw logging and view with a hex editor. This would display the preamble and postamble data on lines above and below the packet data with perhaps a different color to delineate them.

@jmthomas jmthomas added the feature label Nov 17, 2016

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball Jun 22, 2017

Member

preamble/postamble isn't viable, but we could have the interface save the data from the most recent low level read/write. That would be a great feature.

Member

ryanatball commented Jun 22, 2017

preamble/postamble isn't viable, but we could have the interface save the data from the most recent low level read/write. That would be a great feature.

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball Jun 22, 2017

Member

Need to wait for the protocol change to be merged before implementing this. Raw data can be saved at read_interface_base and write_interface_bace

Member

ryanatball commented Jun 22, 2017

Need to wait for the protocol change to be merged before implementing this. Raw data can be saved at read_interface_base and write_interface_bace

@ryanatball ryanatball assigned ryanatball and unassigned donaldatball Jul 3, 2017

@ryanatball

This comment has been minimized.

Show comment
Hide comment
@ryanatball

ryanatball Jul 5, 2017

Member

closed by pull request #361

Member

ryanatball commented Jul 5, 2017

closed by pull request #361

@ryanatball ryanatball closed this Jul 5, 2017

@ryanatball ryanatball modified the milestone: v4.0.0 Aug 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment