New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Manager refactoring #369

Closed
jmthomas opened this Issue Nov 29, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@jmthomas
Member

jmthomas commented Nov 29, 2016

Table Manager needs some work as it has not been touched since the initial COSMOS 2.0 work.

Issue list:
After editing values aren't saved unless the user hits Return. Save on losing focus.
The Check methods automatically revert values to default. Don't do this.
Save reverts values without notifying the user. Save should call check first.
table_config parser should probably subclass packet_parser and packet_item_parser. There's lots of overlap.
Better delineation of where to insert custom code / GUI items.
Duplication displaying hex values when compared to existing hex dialogs.

@jmthomas jmthomas self-assigned this Nov 29, 2016

@jmthomas

This comment has been minimized.

Show comment
Hide comment
@jmthomas

jmthomas Jan 18, 2017

Member

Closed by merging #376

Member

jmthomas commented Jan 18, 2017

Closed by merging #376

@jmthomas jmthomas closed this Jan 18, 2017

@ryanatball ryanatball modified the milestone: v3.9.1 Mar 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment